Skip to content

Skip test_rgw_keda_ha in external mode#15129

Merged
udaysk23 merged 1 commit into
red-hat-storage:masterfrom
sagihirshfeld:fix-test-rgw-keda-ha-external-mode
May 18, 2026
Merged

Skip test_rgw_keda_ha in external mode#15129
udaysk23 merged 1 commit into
red-hat-storage:masterfrom
sagihirshfeld:fix-test-rgw-keda-ha-external-mode

Conversation

@sagihirshfeld
Copy link
Copy Markdown
Contributor

@sagihirshfeld sagihirshfeld commented May 13, 2026

Summary

  • The enable_rgw_hpa fixture annotates ocs-storagecluster, which does not exist in external mode (ocs-external-storagecluster)
  • Beyond the name mismatch, the test requires installing KEDA via Helm on the cluster where RGW runs. In external mode that cluster is not managed by OCS-CI, so
    setting up KEDA and its prerequisites there is out of scope
  • Added @skipif_external_mode to TestKedaHA, consistent with other RGW tests in the same directory

@sagihirshfeld @claude
Skip test_rgw_keda_ha in external mode
8f66444 
The enable_rgw_hpa fixture annotates the StorageCluster using
the internal-mode name (ocs-storagecluster), which does not
exist in external mode deployments.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Sagi Hirshfeld <shirshfe@redhat.com>
@sagihirshfeld sagihirshfeld self-assigned this May 13, 2026
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner May 13, 2026 07:59
@sagihirshfeld sagihirshfeld added RGW Issues related to the Ceph Object Gateway Squad/Red labels May 13, 2026
@sagihirshfeld
Copy link
Copy Markdown
Contributor Author

sagihirshfeld commented May 13, 2026

Adding the Verified label to the limited nature of the change

@sagihirshfeld sagihirshfeld added the Verified Mark when PR was verified and log provided label May 13, 2026
@sagihirshfeld
Copy link
Copy Markdown
Contributor Author

sagihirshfeld commented May 13, 2026

/cherry-pick release-4.21

@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

openshift-cherrypick-robot commented May 13, 2026

@sagihirshfeld: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sagihirshfeld
Copy link
Copy Markdown
Contributor Author

sagihirshfeld commented May 13, 2026

/cherry-pick release-4.20

@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

openshift-cherrypick-robot commented May 13, 2026

@sagihirshfeld: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ypersky1980
ypersky1980 approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci Bot added the lgtm label May 18, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld, udaysk23, ypersky1980

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@udaysk23 udaysk23 merged commit ed84545 into red-hat-storage:master May 18, 2026
7 of 8 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

openshift-cherrypick-robot commented May 18, 2026

@sagihirshfeld: #15129 failed to apply on top of branch "release-4.20":

Applying: Skip test_rgw_keda_ha in external mode
Using index info to reconstruct a base tree...
A	tests/functional/object/rgw/test_keda_ha.py
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): tests/functional/object/rgw/test_keda_ha.py deleted in HEAD and modified in Skip test_rgw_keda_ha in external mode. Version Skip test_rgw_keda_ha in external mode of tests/functional/object/rgw/test_keda_ha.py left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Skip test_rgw_keda_ha in external mode
Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 18, 2026
Open
@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

openshift-cherrypick-robot commented May 18, 2026

@sagihirshfeld: new pull request created: #15173

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@udaysk23 udaysk23 udaysk23 approved these changes

@ypersky1980 ypersky1980 ypersky1980 approved these changes

@nehaberry nehaberry Awaiting requested review from nehaberry

Assignees

@sagihirshfeld sagihirshfeld

@udaysk23 udaysk23

@ypersky1980 ypersky1980

Labels

lgtm RGW Issues related to the Ceph Object Gateway size/XS Squad/Red Verified Mark when PR was verified and log provided

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sagihirshfeld @openshift-cherrypick-robot @udaysk23 @ypersky1980